feat: Uv take 3, no pyproject.toml and with pinned setuptools and wheel #5369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuarli
commented
Nov 11, 2025
joshuarli
commented
Nov 12, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
jjbayer
approved these changes
Nov 12, 2025
Member
jjbayer
left a comment
jjbayer
left a comment
There was a problem hiding this comment.
Let's try it! I did a few smoke tests, like running python setup.py sdist and committing badly formatted python, that all seems to work 👍 .
I can cut a release of the python library right after merging so there are no surprises at a later point.
Comment on lines
+6
to
+7
| # TODO: reactivate when fixed | ||
| # - id: check-github-workflows |
Member
There was a problem hiding this comment.
Is this TODO for this PR, or for later?
Member
Author
There was a problem hiding this comment.
\shrug
joshuarli
changed the title
…t-toml-with-pinned-setuptools
joshuarli
deleted the
feat-uv-no-pyproject-toml-with-pinned-setuptools
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings back my uv pr without pyproject.toml and with pinned setuptools and wheel.
The original error doesn't refer to which artifact failed to upload and in fact it is referring to the two macos wheels in the release artifact here. These wheels have metadata 2.1 but also Dynamic fields which are a 2.2+ thing.
I determined this was due to pinning wheel 0.42.0 in my uv pr which produces bad macos wheels. 0.45.1 works. This worked before because in CI we were installing unpinned (latest) setuptools+wheel.
I wrote a small script that reproduced twine's upload fail here (wheel 0.42.0) so that we can error out before actions/upload-artifact and before any release artifacts are published to github.
#skip-changelog